Experimental/custom elements #144
Conversation
|
Docs available on https://illright.github.io/attractions/144/ |
demo/index.html
Outdated
|
|
||
| <body> | ||
| <a-card> | ||
| <a-button filled="true" danger="true"> |
There was a problem hiding this comment.
is it even possible to use any props that are not boolean or string? I'm pretty sure HTML treats all props as strings
There was a problem hiding this comment.
Right, but a string is still truthy, so we should be ok here as long as we don't compare with === true or similar. About other data types, that still needs investigation
demo/index.html
Outdated
| Alert | ||
| </a-button> | ||
| <!-- camelCase props seem to not work (HTML is case-insensitive) --> | ||
| <a-switch slotLeft="true"> |
There was a problem hiding this comment.
maybe we should reconsider the way we name our boolean and string props to be compatible with this
There was a problem hiding this comment.
Or not rename, but add an "alias", perhaps
There was a problem hiding this comment.
I mean another prop that would act as a fallback. If slotLeft is false (or maybe null or some other default signifying its absence), check the value of slotleft. But that's kinda hacky and I don't like it.
Do we even have that many important props with camelCase names? I mean, people can still use .$$set
|
Damn, I should have read the PR description a little more carefully) oh well, let's keep those comments as discussion threads |
Makes them accessible without using a bundler
since it is already copied to the docs as an example
Since it was not clear how to use the compiled JS version of the components, the purpose of this PR is to change it to use the easier Web Components API.
To do:
$$set.