Улучшение SubtitlesWidget #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Переработал компонент SubtitlesWidget, значительно упростив код за счет использования метода findLast, который поддерживается браузерами начиная с 2022 года. Надеюсь, полифиллы не понадобятся. Нужно протестировать.
|
При перетаскивание курсор начал уходить на некоторое расстояние от блока с субтитрами |
|
@ilyhalight Проблема ушла? |
Да, но появилась другая. В расширенном режиме (theater mode) на ютубе, при попытке перетащить субтитры, они теперь улетают в левую часть видео и фиксируются там chrome_ZzCRCtc5dk.mp4 |
|
@ilyhalight Проблем больше нет? |
Пофикшено |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Переработал компонент SubtitlesWidget, значительно упростив код. Нужно протестировать.