Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes test files (less than 1kB currently) when publishing the crate. See below for the motivation.
This is a recent regression
My recent PR (#28) has broken an ability to run
fdeflate
tests on top of the version published to crates.io.Motivation for running tests against crates.io release
It seems that in some scenarios running tests against crates.io release is desirable:
IIUC the consensus at https://users.rust-lang.org/t/what-to-include-when-publishing-a-crate/51992/16 seems to be:
This PR seems reasonable
It seems to me that this PR is reasonable for
fdeflate
, but I am not 100% sure about this.Alternatives:
tests/
directory:#[cfg(...)]
Other notes:
cargo test
in a package downloaded from crates.iopng
) is quite big and would exceed the cap of package size. Therefore we can't include all tests for all crates.