Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possiblity to encode pixel dimensions #403

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

Fight-For-Food
Copy link
Contributor

No description provided.

@jonmmease
Copy link

Hi, I maintain a crate that depends on image-png and would be interested in this functionality as well. Is there anything I can do to help?

I tested against this branch and everything works as expected for my application (VlConvert).

jonmmease added a commit to vega/vl-convert that referenced this pull request Jul 17, 2023
jonmmease added a commit to vega/vl-convert that referenced this pull request Jul 17, 2023
@fintelia
Copy link
Contributor

Thanks for testing, that sort of check is super helpful!

@Fight-For-Food could you run cargo fmt to resolve the couple issues detected by CI? Other than that, this looks ready to merge

@fintelia fintelia merged commit 3b3f2e3 into image-rs:master Jul 18, 2023
19 checks passed
@Fight-For-Food
Copy link
Contributor Author

Sorry for delay about fixing this PR. I am new with open source development.
I tried to use cargo fmt, but my personal settings are different with format of this project, and cargo fmt affect every source file. So I fix this CI check by my hands.
@fintelia Maybe there is a good idea to add some .rustfmt.toml to this repository?

@Fight-For-Food Fight-For-Food deleted the ppu branch July 18, 2023 06:51
@jonmmease
Copy link

Thanks @Fight-For-Food and @fintelia!

No rush, but do you have an estimate of when this functionality will be released to crates.io?

@fintelia
Copy link
Contributor

The crate release schedule is mostly "cut a release when someone asks for one", so I'll try to get a new release out soon. Hopefully no more than a week or two

@jonmmease
Copy link

Perfect, thank you!

@jonmmease
Copy link

friendly ping regarding a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants