-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workaround when ConvertService can operate on python types #220
Comments
There are valid |
JPype likely won't ever support conversion of a tuple because it has no Java type unless there is some generic container type what it could be mapped to. Can I ask what code triggered this particular error? (what is in the tuple and what should it convert to?) |
@ctrueden @hinerm the commit making that line isn't wrong per se, it just stinks that python objects can reach that code. It's worth noting that this happens because in pyimagej there's a redundant conversion in @Thrameos it's definitely not an issue with JPype, and I think your reasoning about not supporting tuple conversion is correct. The tuple contains napari |
Note that scijava/scyjava#60 should enable us, when we can depende on it, to remove these checks |
And bump minimum scyjava version to 1.9.1. As of scyjava 1.9.1, the work from scijava/scyjava#60 is integrating, meaning such defensive checks around conversion are no longer necessary. This reverts commit 85f0d5c, titled "Work around jpype convert limitation", and closes #220. It also removes some other usages of isjava, which are also not needed.
And bump minimum scyjava version to 1.9.1. As of scyjava 1.9.1, the work from scijava/scyjava#60 is integrated, meaning such defensive checks around conversion are no longer necessary. This reverts commit 85f0d5c, titled "Work around jpype convert limitation", and closes #220. It also removes some other usages of isjava, which are also not needed.
This commit adds a workaround to a JPype limitation. Without it, when trying to convert python types (even if a valid converter implementation exists) we get this error:
When this is fixed in Jpype we can remove the workaround
The text was updated successfully, but these errors were encountered: