Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended_versions #264

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Add recommended_versions #264

merged 6 commits into from
Oct 14, 2024

Conversation

gselzer
Copy link
Collaborator

@gselzer gselzer commented Jun 6, 2023

This enables us to suggest users upgrade their versions without forcing them to do so.

In this way, we allow users to upgrade their napari-imagej package without updating their ImageJ, but also being able to "rely" on newer Java component versions.

@gselzer gselzer added the enhancement New feature or request label Jun 6, 2023
@gselzer gselzer added this to the 0.2.0 milestone Jun 6, 2023
@gselzer gselzer requested review from ctrueden and hinerm June 6, 2023 16:20
@gselzer gselzer self-assigned this Jun 6, 2023
@gselzer gselzer linked an issue Jun 6, 2023 that may be closed by this pull request
@gselzer gselzer force-pushed the 255-bump-ops-recommended-minimum branch 2 times, most recently from 2d83c4c to 982fe62 Compare June 6, 2023 16:29
@gselzer
Copy link
Collaborator Author

gselzer commented Jun 16, 2023

TODO: Bump recommended scijava-search version to include scijava/scijava-search#30

@gselzer gselzer linked an issue Jun 16, 2023 that may be closed by this pull request
@gselzer gselzer force-pushed the 255-bump-ops-recommended-minimum branch from 982fe62 to 5dd4fb4 Compare July 20, 2023 16:07
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (75cedb6) 88.51% compared to head (5dd4fb4) 88.62%.
Report is 2 commits behind head on main.

❗ Current head 5dd4fb4 differs from pull request most recent head 8a71ad8. Consider uploading reports for the commit 8a71ad8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   88.51%   88.62%   +0.11%     
==========================================
  Files          53       53              
  Lines        4912     4942      +30     
==========================================
+ Hits         4348     4380      +32     
+ Misses        564      562       -2     
Files Changed Coverage Δ
src/napari_imagej/java.py 94.31% <100.00%> (+0.18%) ⬆️
tests/test_java.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gselzer
Copy link
Collaborator Author

gselzer commented Jul 20, 2023

While this works, it'd be cool to get new versions of imagej-ops and scijava-search to pin here, so that we can get imagej/imagej-ops#651 and scijava/scijava-search#30 pinned as "recommended minimums".

Pinging @hinerm.

@gselzer gselzer force-pushed the 255-bump-ops-recommended-minimum branch from 5dd4fb4 to 89032c4 Compare July 20, 2023 21:11
@gselzer
Copy link
Collaborator Author

gselzer commented Jul 27, 2023

After talking with @hinerm and @ctrueden, we might want to push a minimum imagej version as well - I think 2.10.0?

@gselzer gselzer force-pushed the 255-bump-ops-recommended-minimum branch 2 times, most recently from c0a9094 to 8a71ad8 Compare August 1, 2023 21:23
@gselzer gselzer linked an issue Aug 1, 2023 that may be closed by this pull request
@gselzer
Copy link
Collaborator Author

gselzer commented Aug 1, 2023

I added on a commit here to recommend ImageJ2/Fiji 2.10.0, so this PR will also close #289

This enables us to suggest users upgrade their versions without forcing
them to do so.
@gselzer gselzer force-pushed the 255-bump-ops-recommended-minimum branch from 8a71ad8 to fff47e9 Compare October 11, 2024 21:59
Since imagej2 has no minimum, we also have to add a bit of framework for
recommended versions that AREN'T minimum versions
@gselzer gselzer force-pushed the 255-bump-ops-recommended-minimum branch 2 times, most recently from 41666a8 to c63259d Compare October 14, 2024 21:08
...Just use logger.warning!

We can always re-add in the dialog box if people find they're missing
the warnings
This simplicity makes it easier to add our own logging implements later
on.
@gselzer gselzer force-pushed the 255-bump-ops-recommended-minimum branch from c63259d to 9a5b952 Compare October 14, 2024 21:20
@gselzer gselzer merged commit 5776331 into main Oct 14, 2024
8 checks passed
@gselzer gselzer deleted the 255-bump-ops-recommended-minimum branch October 14, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants