-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch SearchResult display to model/view paradigm #290
Switch SearchResult display to model/view paradigm #290
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 88.51% 88.28% -0.24%
==========================================
Files 53 53
Lines 4912 4925 +13
==========================================
Hits 4348 4348
- Misses 564 577 +13
☔ View full report in Codecov by Sentry. |
2db5d2e
to
2d95b4f
Compare
We aren't implementing this behavior anymore (it's the default with QTreeView), so we don't need to test it.
...jpype is so smart!
2d95b4f
to
5d97895
Compare
On MacOS, this prevents the categories from being highlighted
We haven't coded this behavior, so let's not test it!
5d97895
to
173e336
Compare
This PR now loads all icons stored as resources within jars. It does not yet load icons from the web, mostly due to performance implications. Filed #296 to track that item. |
@gselzer Can you give an example of an icon referenced via a remote URL in this way? |
For example, the user icons from |
1d509d4
to
1ee96af
Compare
1ee96af
to
9b2d5a1
Compare
This PR converts the search result
QTreeWidget
to use Qt's model/view paradigm - not only is this a better separation of concerns, but it also makes it easier to do things like adding icons to search results.