Add support for arm64 and update mozjpeg 4.1.3 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows building is broken. It has to be fixed. I recommend using vcpkg. Mac Os X arm64 binary should be change to real arm64 binary. I don't own mac, but everything builds correctly.
|
@MateuszKrawczuk |
|
@1000ch |
|
@1000ch In mozjpeg-v4.1.3 and mozjpeg-v4.1.1 on windows it requires to copy libraries even if it uses static cjpeg. I think I should report issue in https://github.com/mozilla/mozjpeg/ with cjpeg-static.exe. That why I don't copy cjpeg-static.exe and copy smaller cjpeg.exe. Maybe it is issue related with building using Microsoft Visual Studio Build tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows building is not really implemented. Somebody should fix this in future. I recommend using vcpkg for providing zlib and libpng.
Mac Os X arm64 binary is placeholder now and it should be change to real arm64 binary.