Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude spec files from gem package #57

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

amatsuda
Copy link
Contributor

Here's a patch that excludes spec files from the gem package.

With this patch, the .gem file size diminishes from 28672 bytes to 23040 bytes on current master.

@imanel
Copy link
Owner

imanel commented Jul 18, 2024

Interesting, looks like somewhere along the way test_files was dropped from the spec. Good catch.

Test in 2.1 failed because grep_v was added in Ruby 2.3. Could you switch to grep with negative regex or to select / find_all?

also, excluded the following five files as well:

.codeclimate.yml
.github/workflows/publish.yml
.github/workflows/test.yml
.gitignore
.rubocop.yml
@amatsuda
Copy link
Contributor Author

Test in 2.1 failed because grep_v was added in Ruby 2.3. Could you switch to grep with negative regex or to select / find_all?

Oops! Pushed another commit doing this.

@imanel imanel merged commit 8f9f4c1 into imanel:master Jul 24, 2024
13 checks passed
@imanel
Copy link
Owner

imanel commented Jul 24, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants