Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added facewear and some small tweaks. #1379

Merged
merged 10 commits into from
Sep 3, 2024

Conversation

CaptainSticky
Copy link
Contributor

This pull request adds the ability for users to change their facewear (glasses).

Facewear can be set underneath the "Sub Actors And Facewear" section on the character page. Middle clicking on the icon will clear the glasses and left click will open a drawer to select and favorite any of the glasses in the game. More so, the buttons at the top of the equipment tab for equipping racial gear, small clothes, NPC small clothes, and emperor's will clear the glasses.

I also added the following tweaks/niceties:

  • Added a button to equip full Emperor's New gear; 279-1 for the left side and 53-1 for the right side.
  • Added a tooltip to the gear name headers for each slot, so that you can see what the full name is when it gets cut off.

Copy link
Contributor

@ergoxiv ergoxiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good work on the main feature. Everything seems to work well. I left some comments on the code itself and some questions on the reasoning behind some of the secondary features as I think it would be nice to have further discussion on them.

Anamnesis/Memory/ActorMemory.cs Show resolved Hide resolved
Anamnesis/Memory/GlassesMemory.cs Outdated Show resolved Hide resolved
Anamnesis/Languages/en.json Outdated Show resolved Hide resolved
Anamnesis/Languages/en.json Outdated Show resolved Hide resolved
Anamnesis/Services/FavoritesService.cs Outdated Show resolved Hide resolved
Anamnesis/Actor/Views/ItemView.xaml Outdated Show resolved Hide resolved
Anamnesis/Actor/Extensions/ItemSlotsExtensions.cs Outdated Show resolved Hide resolved
Anamnesis/Actor/Views/GlassesItemView.xaml Outdated Show resolved Hide resolved
Anamnesis/GameData/Excel/Glasses.cs Show resolved Hide resolved
Anamnesis/GameData/Excel/Glasses.cs Outdated Show resolved Hide resolved
Made the favorites service generic for IsFav and SetFav.
Removed accidental commit of Hat Vis offsets.
@StoiaCode
Copy link
Contributor

Quite extensive changes. Looking good as far as I can tell. The placement of the Facewear slot is also logical, and I see youve already debated the added button. Ergoxiv already cought most things here, so thanks!

@StoiaCode StoiaCode merged commit 04737d9 into imchillin:master Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants