Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lb4/datahub rest emitter init #1

Closed
wants to merge 10 commits into from
Closed

Lb4/datahub rest emitter init #1

wants to merge 10 commits into from

Conversation

xdxxxdx
Copy link

@xdxxxdx xdxxxdx commented Aug 28, 2023

Add datahub emitter to the edc connector

idris52 added 2 commits August 25, 2023 13:42
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 28, 2023
View reviewed changes
...t-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/DatasetEntityIngestor.java Dismissed Show dismissed Hide dismissed
...t-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/DatasetEntityIngestor.java Dismissed Show dismissed Hide dismissed
...t-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/DatasetEntityIngestor.java Fixed Show fixed Hide fixed
...nt-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/DomainEntityIngestor.java Dismissed Show dismissed Hide dismissed
...nt-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/RelationshipIngestor.java Dismissed Show dismissed Hide dismissed
...ment-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/UserEntityIngestor.java Dismissed Show dismissed Hide dismissed
...nt-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/PolicyEntityIngestor.java Dismissed Show dismissed Hide dismissed
...t-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/DatasetEntityIngestor.java Fixed Show fixed Hide fixed
github-actions[bot]
github-actions bot reviewed Aug 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@github-actions
Copy link

github-actions bot commented Aug 28, 2023 •
edited
Loading

Test Results

     555 files   - 22       555 suites   - 22   22m 42s ⏱️ -40s
12 500 tests  - 72  12 492 ✔️  - 73  7 💤 ±0  1 ❌ +1 
12 741 runs   - 72  12 733 ✔️  - 73  7 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit bc2585b. ± Comparison against base commit 36f5a71.

This pull request removes 167 and adds 95 tests. Note that renamed tests count towards both. 
org.eclipse.edc.connector.api.management.policy.PolicyDefinitionApiExtensionTest ‑ initialize_shouldRegisterValidatorForPolicyDefinition(ServiceExtensionContext)
org.eclipse.edc.connector.api.management.policy.PolicyDefinitionApiTest ‑ policyDefinitionInputExample()
org.eclipse.edc.connector.api.management.policy.PolicyDefinitionApiTest ‑ policyDefinitionOutputExample()
org.eclipse.edc.connector.api.management.policy.transform.JsonObjectFromPolicyDefinitionTransformerTest ‑ transform()
org.eclipse.edc.connector.api.management.policy.transform.JsonObjectFromPolicyDefinitionTransformerTest ‑ types()
org.eclipse.edc.connector.api.management.policy.transform.JsonObjectToPolicyDefinitionTransformerTest ‑ transform()
org.eclipse.edc.connector.api.management.policy.transform.JsonObjectToPolicyDefinitionTransformerTest ‑ types()
org.eclipse.edc.connector.api.management.policy.validation.PolicyDefinitionValidatorTest ‑ shouldFail_whenIdIsBlank()
org.eclipse.edc.connector.api.management.policy.validation.PolicyDefinitionValidatorTest ‑ shouldFail_whenPolicyIsMissing()
org.eclipse.edc.connector.api.management.policy.validation.PolicyDefinitionValidatorTest ‑ shouldSucceed_whenObjectIsValid()
…

be.imec.edit.ds.catalog.DataSpaceCatalogTest ‑ ingestDataSetEntity()
org.eclipse.edc.connector.callback.staticendpoint.CallbackStaticEndpointExtensionTest ‑ [1] {edc.callback.cb.transactional=false, edc.cb.callback.events=test}
org.eclipse.edc.connector.callback.staticendpoint.CallbackStaticEndpointExtensionTest ‑ [2] {edc.callback.cb.transactional=false, edc.callback.cb.uri=url}
org.eclipse.edc.connector.callback.staticendpoint.CallbackStaticEndpointExtensionTest ‑ [3] {edc.callback.cb.uri=url, edc.callback.cb.auth-key=test, edc.callback.cb.events=test, edc.callback.cb.transactional=false}
org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest ‑ [10] ACCEPTING, TERMINATED, java.util.concurrent.CompletableFuture@1ddf42dd[Completed normally], org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest$DispatchFailureArguments$$Lambda$640/0x00007fb3943884a8@5c1c9881
org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest ‑ [11] VERIFYING, TERMINATED, java.util.concurrent.CompletableFuture@22aefae0[Completed normally], org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest$DispatchFailureArguments$$Lambda$641/0x00007fb394388708@20faaf77
org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest ‑ [12] TERMINATING, TERMINATED, java.util.concurrent.CompletableFuture@6c70b7c3[Completed normally], org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest$DispatchFailureArguments$$Lambda$642/0x00007fb394388968@16a09809
org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest ‑ [1] REQUESTING, REQUESTING, java.util.concurrent.CompletableFuture@52433946[Completed exceptionally: org.eclipse.edc.spi.EdcException: error], org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest$DispatchFailureArguments$$Lambda$631/0x00007fb3943811f8@5403431a
org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest ‑ [2] ACCEPTING, ACCEPTING, java.util.concurrent.CompletableFuture@542ff147[Completed exceptionally: org.eclipse.edc.spi.EdcException: error], org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest$DispatchFailureArguments$$Lambda$632/0x00007fb394381458@2d801d8
org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest ‑ [3] VERIFYING, VERIFYING, java.util.concurrent.CompletableFuture@41be8db9[Completed exceptionally: org.eclipse.edc.spi.EdcException: error], org.eclipse.edc.connector.contract.negotiation.ConsumerContractNegotiationManagerImplTest$DispatchFailureArguments$$Lambda$633/0x00007fb3943816b8@2c2a7d53
…

♻️ This comment has been updated with latest results.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 31, 2023
View reviewed changes
...t-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/DatasetEntityIngestor.java

//set and emit data schema aspect to metadata model of datahub
Future<MetadataWriteResponse> schemaPropsFut = emitter.emit(_metadataChangeProposalWrapper(_schemaMetadata(asset), entityType, datasetUrn));
var a = _editableDatasetProperties(asset);

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'EditableDatasetProperties a' is never read.
...t-api/dataspace-catalog-api/src/main/java/be/imec/edit/ds/catalog/DatasetEntityIngestor.java
* */

public class DatasetEntityIngestor extends DataSpaceCatalogIngestorBase {
Logger log = LoggerFactory.getLogger(this.getClass().getName());

Check warning

Code scanning / CodeQL

Field masks field in super class Warning

This field shadows another field called
log
Loading
in a superclass.
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Sep 8, 2023
@xdxxxdx xdxxxdx closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xdxxxdx @kkostov