-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding WikiCompress #506
Adding WikiCompress #506
Conversation
hey nice start here! Check the compile error in |
good call on preventing the infinite loop here 👍 |
I just ran through a test of this and what we got so far is working great! Good job 😄 There's not too much left to wrap this feature up. Based on the discussion in #461, we need to skip the branch change for the wiki clone since there is no pull request UI or branch management for wikis. There are 2 places where we deal with the branch in the CompressImages routine Also, we should return And lastly I think we could use a log statement right where we are adding to Let me know how it goes 👍 |
I decided to still return true if compression went fine, but added If-statement to see if it was for a Wiki repo to still do some logging in Probably would be nice to do some splitting, since it starts to become quite some if-statements. 😸 |
Great idea. Makes more sense to return true for didCompress 👍 For sure, if it ends up getting any crazier than this we should fully split. We landed some changes to the way default branch is decided yesterday. I saw you resolved the conflicts! I'll make sure everything is playing nicely together and then merge it all in Awesome work! |
Got this all tested and integrated now! |
Nice job! |
Retrieving compressImagesMessages queue, adding entry if WikiCompress is enabled.
Not sure if this is enough to prevent recursion?
if (repoConfiguration.CompressWiki && !parameters.CloneUrl.Contains(".wiki.gi"))