Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No joy yet with version 0.1.20 #4

Closed
thewtex opened this issue Nov 14, 2023 · 5 comments · Fixed by #5 or #7
Closed

No joy yet with version 0.1.20 #4

thewtex opened this issue Nov 14, 2023 · 5 comments · Fixed by #5 or #7

Comments

@thewtex
Copy link
Contributor

thewtex commented Nov 14, 2023

@oeway thanks for the recent bump for Jupyter 4!

Installation succeeds, and I do see:

fd:1 JupyterLab extension imjoy-jupyterlab-extension is activated!

in the browser console. However, there is no ImJoy icon in the notebook bar or cell output either with the test at the bottom of the project README or with itkwidgets.

image

@oeway
Copy link
Contributor

oeway commented Nov 29, 2023

That's wired, I tested it with the latest Jupyter lab and it seems to be working. Will check when I have a slot.

@oeway
Copy link
Contributor

oeway commented Nov 29, 2023

@thewtex Thanks, I have just fixed it, please try it with imjoy-jupyterlab-extension==0.1.21. The previous version miss several files (removed by the upgrades scripts) and somehow my test notebook used the old version.

Anyway, it suppose to work now, if not please reopen the issue!
Edit: oops, it seems the new extension is not loading, I will see how I can fix it and get back to you.

@oeway oeway reopened this Nov 29, 2023
@thewtex
Copy link
Contributor Author

thewtex commented Dec 1, 2023

@oeway thanks for your attention to this!

@oeway oeway closed this as completed in #7 Apr 5, 2024
@oeway
Copy link
Contributor

oeway commented Apr 5, 2024

Hi @thewtex Finally, sorry for the delay! The new jupyterlab should be supported now.
https://pypi.org/project/imjoy-jupyterlab-extension/

P.S. It was not easy to get it work, the whole jupyter extension system is so fragile and I couldn't easily get things work together.

@thewtex
Copy link
Contributor Author

thewtex commented Apr 14, 2024

@oeway thank you so much for the effort and attention to this! Awesome to have it updated!

P.S. It was not easy to get it work, the whole jupyter extension system is so fragile and I couldn't easily get things work together.

Yes, I have also experienced this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants