Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installer main window. #733

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

bitbound
Copy link
Collaborator

@bitbound bitbound commented Sep 8, 2023

During earlier refactoring, we put the default window chrome (titlebar, etc.) back into all windows. The AllowsTransparency property on the installer's main window was no longer compatible after this change and was causing the app the crash.


Please read the following. Do not delete below this line.

Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Immense Networks, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

@bitbound bitbound self-assigned this Sep 8, 2023
@bitbound bitbound changed the base branch from master to tech/reconnect-after-session-end September 8, 2023 17:22
colinblaise
colinblaise previously approved these changes Sep 11, 2023
Base automatically changed from tech/reconnect-after-session-end to master September 11, 2023 14:35
@bitbound bitbound dismissed colinblaise’s stale review September 11, 2023 14:35

The base branch was changed.

@bitbound bitbound merged commit d8007b6 into master Sep 11, 2023
1 check passed
@bitbound bitbound deleted the bug/fix-installer-main-window branch September 11, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants