Throw when accessing non-draftables in strict mode #715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR attempts to implement the idea from #686
It adds a
strictMode
(false
by default, enabled bysetStrictMode
or passingstrictMode
inImmer
constructor) that makes it so that accessing non-draftable properties will throw an error, unless the access is made in anunsafe
callback.Fixes #686
Example
See the tests for more examples
Limitations
I tried to make it as compliant with existing functionalities as possible. I was not able to make it fully ES5-compliant. There are a few tests that fail when strict mode is enabled in
base.js
tests.I do not have enough expertise to fully fix them. Suggestions are welcome