Revert "Correct inverted stereo images" fixing #132 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 071895b.
As mentioned in #132 the
chess-pano-4kimage incorrectly has the right view on top of the left view ("stereo bottom top") but is treated as ("stereo top bottom"). This causes inverted stereo in the '360 Photos' and 'Equirect Layer' samples.The Meta Quest Browser seems to invert left and right when using
stereo-top-bottomwith an equirect layer, which is probably why the change was made. I verified that after reverting, both samples render correctly with the Pico Browser and the 360 Photos sample renders correctly with the Quest browser. Only the Equirect layer sample regresses on the Quest browser (inverted stereo), due to the aforementioned bugged behaviour.