Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] material used for 2022/03/29 CR publication #1261

Merged
merged 3 commits into from
Apr 1, 2022
Merged

[WIP] material used for 2022/03/29 CR publication #1261

merged 3 commits into from
Apr 1, 2022

Conversation

himorin
Copy link
Member

@himorin himorin commented Mar 25, 2022 •
edited by pr-preview bot
Loading

lines added for upcoming 2022/03/29 CR publication

Preview | Diff

toji
toji approved these changes Mar 26, 2022
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good at this point, approving preemptively. Let us know if any changes/additions need a re-review before it's time to land.

@himorin
Copy link
Member Author

himorin commented Mar 26, 2022

CR material out with this PR applied.
how do you want to archive (or tagging in github?) for this release? I think we've tagged for FPWD

note, for streamlined publication as CRD, none of lines with this PR are used (or just ignored for status, date and deadline).

@Manishearth
Copy link
Contributor

how do you want to archive (or tagging in github?) for this release? I think we've tagged for FPWD

We can probably tag it as cr? I'm not sure what we need here.

Also, @himorin, is there a reason this is just this spec and not the AR/Gamepads modules as well? Or are those going to happen after this one hits CR?

@himorin
Copy link
Member Author

himorin commented Mar 27, 2022

Also, @himorin, is there a reason this is just this spec and not the AR/Gamepads modules as well? Or are those going to happen after this one hits CR?

As in the last IWWG call, we first need to prepare HR self review check lists, and pass HRs with completed lists.

himorin added a commit to himorin/webxr that referenced this pull request Mar 31, 2022
@himorin
check failure could be solved with this,,, (one line copied from imme…
5dd34e8 
…rsive-web#1261)
@himorin
Copy link
Member Author

himorin commented Apr 1, 2022

merging this, and will tag as CRS-20220331 asap.

@himorin himorin merged commit b919cdb into main Apr 1, 2022
github-actions bot added a commit that referenced this pull request Apr 1, 2022
@himorin @github-actions
Merge pull request #1261 from immersive-web/archive-cr-202203
ee94770 
SHA: b919cdb
Reason: push, by @himorin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@toji toji toji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@himorin @Manishearth @toji