fix(mobile): consider manual upload when darkening screen #11917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saschl
changed the title
|
Usually, for manual upload, I don't expect the user to leave the phone open for long. So I don't think we need this mechanism here, to keep the logic simple |
I see your point, just thought it would be more consistent and a bit less confusing to the user as the behaviour on the backup page would be the same then. But your call in the end 👍 |
|
Closing this PR per the previous comment. Thanks for opening it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
I noticed the manual upload was not considered in the current logic. Added a simple check to also apply the mechanism to the manual uploads/backups (hopefully the last change for this functionality :D )