feat: tags #11980

jrasm91 · 2024-08-22T19:38:31Z

Warning

NOTE: deleting an entire tag will not sync tags change to impacted asset sidecars at the moment. Re-running metadata extract will most likely recreate the tags again. Untagging the assets and then deleting that tag should be fine though.

Add support for tags

Read TagsList and Keywords from exif
Any / character in a tag in interpreted to mean nested tags
Any parents that don't exist will be created
Uniqueness is determined by absolute path (Parent1/Child, Parent2/Child, and Child are all unique tags)
When assets are tagged, the tags and written to TagList in the associated XMP sidecar file
When assets are untragged the updated tag list is written as per the above statement (with the exception of deleting an entire tag).
You can give a tag a color using hex code #123456, although this only is used in the explorer currently. Future work can expand this to the asset detail panel.

Screenshots

Description	Image
Sidebar
Explorer
Tag assets action
Create tag

bo0tzz · 2024-08-22T19:49:43Z

Closes #2168, #3518, #3950.

jrasm91 · 2024-08-23T16:45:35Z

Please don't bring over to this PR the debate of sidecar vs originals, which has already been answered several times elsewhere. This discussion should be centered around the technical implementation of the feature. The major design decision have already been made:

Read tags from xmp
Write tags to xmp
Dedicated tag table
Many to many between assets and tags
Tag explorer
Viewing parent tag implies seeing assets linked to all children
View tags in asset detail panel
Add new tags
Delete existing tags
Add/remove tags in bulk via mult-select option
Eventually add multiple tags at once to a set of assets

e2e/src/api/specs/tag.e2e-spec.ts

server/src/migrations/1724790460210-NestedTagTable.ts

web/src/lib/components/forms/tag-asset-form.svelte

web/src/lib/components/photos-page/actions/tag-action.svelte

web/src/lib/utils/asset-utils.ts

web/src/routes/(user)/tags/[[photos=photos]]/[[assetId=id]]/+page.svelte

web/src/routes/(user)/tags/[[photos=photos]]/[[assetId=id]]/+page.ts

waclaw66 · 2024-08-29T18:30:45Z

Would it be possible to add option item for Tags and Folders to hide those from Library section same as for People and Sharing? They take up space at the expense of the storage and version info below on small screens.

alextran1502 · 2024-08-29T18:34:40Z

@waclaw66 yep, see #12099

danieldietzler

Great job!

ilyaChuk · 2024-08-30T22:09:41Z

Please pay attention #12165

…0 (#2857) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/immich-app/immich-machine-learning](https://github.com/immich-app/immich) | minor | `v1.112.1-cuda` -> `v1.113.0-cuda` | | [ghcr.io/immich-app/immich-server](https://github.com/immich-app/immich) | minor | `v1.112.1` -> `v1.113.0` | --- ### Release Notes <details> <summary>immich-app/immich (ghcr.io/immich-app/immich-machine-learning)</summary> ### [`v1.113.0`](https://github.com/immich-app/immich/releases/tag/v1.113.0) [Compare Source](immich-app/immich@v1.112.1...v1.113.0) ##### v1.113.0 > \[!WARNING] > > ## Breaking changes > > For **OAuth users**, please replace `app.immich:/` with `app.immich:///oauth-callback` for the Redirect URI in your OAuth provider settings ##### Highlights Welcome to release `v1.113.0` of Immich! This is one of the biggest releases yet, introducing some of the most requested features since the early days of Immich. Let's dive right into what we have in place for this release: - Folder view - Tags - Timeline improvements - Library refresh stability - Mobile album sync ##### Folder view You can now browse your photos and videos by folder like in a file explorer. You can use the storage template migration feature for the best experience with uploaded assets in this view. This feature is especially useful for scanned photos, which are difficult to put in a timeline. It has been a long-requested feature. You can enable this feature from the `Users Settings > Features > Folders`. ![folder-enabled](https://github.com/user-attachments/assets/aab4a16a-0888-49de-b51a-785ef557261a) The UI is currently only available for the web; mobile will come in a subsequent release. ![folder](https://github.com/user-attachments/assets/2786da30-83b3-4168-bb98-180dad53a6a4) ![folder-2](https://github.com/user-attachments/assets/163a3ee8-3c3d-4c98-abb6-9c94eb4b362c) ##### Tags Immich now supports hierarchical tags, with the ability to read existing tags from the `TagList` and `Keywords` exif properties. Any changes to tags made through Immich are also written back to a sidecar file. You can re-run the metadata extraction jobs for all assets to import your existing tags. You can enable this feature from the `Users Settings > Features > Tags`. ![tag-enabled](https://github.com/user-attachments/assets/20a7a99e-13f6-46f2-8744-20dd95d8456b) The UI is currently only available for the web; mobile will come in a subsequent release. https://github.com/user-attachments/assets/d543f531-4b0e-4dcf-8918-e76c7f1b288b ##### Timeline improvements This release introduces a rewrite of the web timeline component. It can now handle a large number of assets in a single day or month and has been successfully tested with a very large data set (over a million assets). Photographers frequently request this since they can easily take thousands of photos in a given day. With these performance improvements, you'll see fewer placeholders while loading, which will make for a more fluid scrolling and scrubbing experience. ##### Library refresh stability In relation to the previous point, the stability of library scanning has improved. Previously, you could run out of memory when starting a refresh with libraries containing millions of assets. Now, we queue the refresh jobs in batches. These enhancements won't make scanning go any faster, but they greatly reduce the likelihood of out-of-memory errors that would cause Immich to crash. ##### Mobile album sync You can now sync or mirror an album from your phone to the Immich server on your account. For example, if you select `Recents`, `Camera` and `Videos` album for backup, the corresponding album with the same name will be created on the server. Once the assets from those albums are uploaded, they will be put into the target albums automatically. You can enable this feature from the album selection in the backup screen. <img src="https://github.com/user-attachments/assets/67b329f5-15ff-4128-af52-4a50df852a07" width="300" alt="sync-album"/> For existing installations, you can sync the already uploaded assets by going to the backup screen and pressing the `Sync` button. <img src="https://github.com/user-attachments/assets/ca0847fd-edab-4ebe-b8e1-093ce7e3cc37" width="300" alt="sync-button"/> Have a wonderful weekend, Cheers! *** ##### Support Immich <p align="center"> <img src="https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExbjY2eWc5Y2F0ZW56MmR4aWE0dDhzZXlidXRmYWZyajl1bWZidXZpcyZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/87CKDqErVfMqY/giphy.gif" width="450" title="SUPPORT THE PROJECT!"> </p> If you find the project helpful, you can support Immich by purchasing a product key at <https://buy.immich.app>. Cheers! 🍻  ##### What's Changed ##### 🚨 Breaking Changes - feat(server): granular permissions for api keys by [@jrasm91](https://github.com/jrasm91) in immich-app/immich#11824 - refactor(server): stacks by [@jrasm91](https://github.com/jrasm91) in immich-app/immich#11453 - fix(server): album statistics endpoint by [@jrasm91](https://github.com/jrasm91) in immich-app/immich#11924 - fix: remove `asset.resized` by [@jrasm91](https://github.com/jrasm91) in immich-app/immich#11983 - fix(mobile): use a valid OAuth callback URL by [@qrkourier](https://github.com/qrkourier) in immich-app/immich#10832 ##### 🚀 Features - feat: folder view by [@davidakerr](https://github.com/davidakerr) in immich-app/immich#11880 - feat(web): Scroll to asset in gridview; increase gridview perf; reduce memory; scrollbar ticks in fixed position by [@midzelis](https://github.com/midzelis) in immich-app/immich#10646 - feat: loading screen, initSDK on bootstrap, fix FOUC for theme by [@midzelis](https://github.com/midzelis) in immich-app/immich#10350 - feat(mobile): preserve mobile album info on upload by [@alextran1502](https://github.com/alextran1502) in immich-app/immich#11965 - feat: tags by [@jrasm91](https://github.com/jrasm91) in immich-app/immich#11980 - feat(web): jump to timeline by [@alextran1502](https://github.com/alextran1502) in immich-app/immich#12117 ##### 🌟 Enhancements - feat(server): do not automatically download android motion videos by [@jrasm91](https://github.com/jrasm91) in immich-app/immich#11774 - feat(web): pasting coordinates by [@michelheusschen](https://github.com/michelheusschen) in immich-app/immich#11866 - feat(web): drag and drop or paste directories for upload by [@simkli](https://github.com/simkli) in immich-app/immich#11879 - feat(web): Left hand navigation for memories by [@carlesalbasboix](https://github.com/carlesalbasboix) in immich-app/immich#11913 - feat(web): my immich shortcut by [@danieldietzler](https://github.com/danieldietzler) in immich-app/immich#12007 - fix(web): show a clearer confirmation message when deleting an unnamed album by [@Snowknight26](https://github.com/Snowknight26) in immich-app/immich#11988 - feat(format): nrw format by [@avsm](https://github.com/avsm) in immich-app/immich#12048 - feat(web): restore scroll position on navigating back to search page by [@alextran1502](https://github.com/alextran1502) in immich-app/immich#12042 - feat(server): Storage template support album condition by [@feyst](https://github.com/feyst) in immich-app/immich#12000 - fix(mobile): Changes in the UI for the image editor pages by [@Yuvi-raj-P](https://github.com/Yuvi-raj-P) in immich-app/immich#12018 - feat(web): announce notifications to screen readers by [@ben-basten](https://github.com/ben-basten) in immich-app/immich#12071 - fix(server): don't crash when refreshing large libraries by [@etnoy](https://github.com/etnoy) in immich-app/immich#7934 - feat(server): sort images in duplicate groups by date by [@GeoffreyFrogeye](https://github.com/GeoffreyFrogeye) in immich-app/immich#12094 - feat(ml): support dynamic scaling by [@rkojedzinszky](https://github.com/rkojedzinszky) in immich-app/immich#12065 - feat(web): navigate assets with gestures (next/prev) by [@kaziu687](https://github.com/kaziu687) in immich-app/immich#11888 - fix(mobile): allow create empty non-shared albums, add proper button colors by [@src52](https://github.com/src52) in immich-app/immich#12103 - feat: user's features preferences by [@alextran1502](https://github.com/alextran1502) in immich-app/immich#12099 - chore(server): log path when generating external thumbnail by [@etnoy](https://github.com/etnoy) in immich-app/immich#12107 ##### 🐛 Bug fixes - fix(web): focus trap inside portal by [@michelheusschen](https://github.com/michelheusschen) in immich-app/immich#11797 - fix(mobile): show correct notification icon for android by [@karthikraja001](https://github.com/karthikraja001) in immich-app/immich#11863 - fix(web): show camera make in search options after searching by [@michelheusschen](https://github.com/michelheusschen) in immich-app/immich#11884 - fix(web): correctly populate the camera model search dropdown by [@Snowknight26](https://github.com/Snowknight26) in immich-app/immich#11883 - fix(server): create shared album from the mobile app does not trigger send email invite by [@alextran1502](https://github.com/alextran1502) in immich-app/immich#11911 - fix(server): do not match live photos across libraries by [@jrasm91](https://github.com/jrasm91) in immich-app/immich#11952 - fix(web): rating stars accessibility by [@ben-basten](https://github.com/ben-basten) in immich-app/immich#11966 - fix(mobile): Fix for incorrectly naming edited files and structure change by [@Yuvi-raj-P](https://github.com/Yuvi-raj-P) in immich-app/immich#11741 - fix: align camera model drop down behavior with other drop downs on web and mobile by [@x24git](https://github.com/x24git) in immich-app/immich#11951 - fix(web): announce current theme to screen reader users by [@ben-basten](https://github.com/ben-basten) in immich-app/immich#12039 - fix(web): show supporter badge for account less than 14 days by [@alextran1502](https://github.com/alextran1502) in immich-app/immich#12058 - fix(web): shared link expiration date accessibility by [@ben-basten](https://github.com/ben-basten) in immich-app/immich#12060 - chore(web): ignore shortcut toggle when entering email and password by [@alextran1502](https://github.com/alextran1502) in immich-app/immich#12082 - chore(web): ensure goto is awaited for login page by [@alextran1502](https://github.com/alextran1502) in immich-app/immich#12087 - fix(server): ensure new exclusion patterns work by [@etnoy](https://github.com/etnoy) in immich-app/immich#12102 - fix(server): skip smtp validation if unchanged by [@michelheusschen](https://github.com/michelheusschen) in immich-app/immich#12111 - fix(mobile): long waiting time for login request when server is unreachable by [@alextran1502](https://github.com/alextran1502) in immich-app/immich#12100 - fix: user specific fields in asset search by [@jrasm91](https://github.com/jrasm91) in immich-app/immich#12125 - fix(web): Device list shows Ubuntu as unknown OS by [@spfncer](https://github.com/spfncer) in immich-app/immich#12127 - fix(web): reset asset grid after changing album order by [@michelheusschen](https://github.com/michelheusschen) in immich-app/immich#12139 ##### 📚 Documentation - fix(docs): read-only affects XMP writing by [@C-Otto](https://github.com/C-Otto) in immich-app/immich#11823 - docs: clarify external domain setting by [@pikapower9080](https://github.com/pikapower9080) in immich-app/immich#11958 - docs: add Immich Kiosk and Immich Power Tools to Community Projects by [@Tyree](https://github.com/Tyree) in immich-app/immich#12055 - docs: mTLS/self signed FAQ entry by [@mmomjian](https://github.com/mmomjian) in immich-app/immich#12074 - docs: external library deletion/edits by [@mmomjian](https://github.com/mmomjian) in immich-app/immich#12079 - docs: sql query for duplicate files by [@mmomjian](https://github.com/mmomjian) in immich-app/immich#12086 - docs: Documentation updates by [@aviv926](https://github.com/aviv926) in immich-app/immich#11516 - docs: update roadmap by [@jrasm91](https://github.com/jrasm91) in immich-app/immich#12126 - fix: README_zh_CN.md link by [@ttzytt](https://github.com/ttzytt) in immich-app/immich#12124 - docs(guide): nginx caching proxy by [@pcouy](https://github.com/pcouy) in immich-app/immich#12140 ##### New Contributors - [@aaronjrodrigues](https://github.com/aaronjrodrigues) made their first contribution in immich-app/immich#11851 - [@karthikraja001](https://github.com/karthikraja001) made their first contribution in immich-app/immich#11863 - [@simkli](https://github.com/simkli) made their first contribution in immich-app/immich#11879 - [@carlesalbasboix](https://github.com/carlesalbasboix) made their first contribution in immich-app/immich#11907 - [@pikapower9080](https://github.com/pikapower9080) made their first contribution in immich-app/immich#11958 - [@davidakerr](https://github.com/davidakerr) made their first contribution in immich-app/immich#11880 - [@x24git](https://github.com/x24git) made their first contribution in immich-app/immich#11951 - [@Tonux599](https://github.com/Tonux599) made their first contribution in immich-app/immich#12027 - [@avsm](https://github.com/avsm) made their first contribution in immich-app/immich#12048 - [@Tyree](https://github.com/Tyree) made their first contribution in immich-app/immich#12055 - [@feyst](https://github.com/feyst) made their first contribution in immich-app/immich#12000 - [@Tiefseetauchner](https://github.com/Tiefseetauchner) made their first contribution in immich-app/immich#11874 - [@qrkourier](https://github.com/qrkourier) made their first contribution in immich-app/immich#10832 - [@GeoffreyFrogeye](https://github.com/GeoffreyFrogeye) made their first contribution in immich-app/immich#12094 - [@rkojedzinszky](https://github.com/rkojedzinszky) made their first contribution in immich-app/immich#12065 - [@kaziu687](https://github.com/kaziu687) made their first contribution in immich-app/immich#11888 - [@src52](https://github.com/src52) made their first contribution in immich-app/immich#12103 - [@spfncer](https://github.com/spfncer) made their first contribution in immich-app/immich#12127 - [@ttzytt](https://github.com/ttzytt) made their first contribution in immich-app/immich#12124 **Full Changelog**: https://github.com/immich-app/immich/compare/v1.112.1... </details> --- - [ ] If you want to rebase/retry this PR, check this box  Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Calvin Bui <[email protected]> Reviewed-on: https://gitea.bui.ng/calvinbui/ansible-monorepo/pulls/2857 Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>

Knuppel1983 · 2024-10-07T13:13:42Z

Does this feature write the tags to the original files? If not can this be added as an option? Or an option to export the tags with the original files?

I want my photo library to be vendor-independant, so i can import / export without having to tag everything all over again...

danieldietzler · 2024-10-07T13:15:45Z

Does this feature write the tags to the original files? If not can this be added as an option? Or an option to export the tags with the original files?

I want my photo library to be vendor-independant, so i can import / export without having to tag everything all over again...

It writes the tags to an XMP sidecar file, just like any other metadata you change within immich

Knuppel1983 · 2024-10-07T16:34:51Z

Does this feature write the tags to the original files? If not can this be added as an option? Or an option to export the tags with the original files?
I want my photo library to be vendor-independant, so i can import / export without having to tag everything all over again...

It writes the tags to an XMP sidecar file, just like any other metadata you change within immich

Ok that will do. Please also add an option to disable smart search, and search by tag only. Some of us don't need machine learning, and it puts a lot of strain on low powered devices.

jrasm91 · 2024-10-07T19:29:09Z

@Knuppel1983 you can already do this from the admin settings.

feat: tags

93169e7

jrasm91 added the changelog:feature label Aug 22, 2024

github-actions bot added 🖥️web 🗄️server labels Aug 22, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as off-topic.

Sign in to view

alextran1502 and others added 19 commits August 23, 2024 15:46

Merge branch 'main' of github.com:immich-app/immich into feat/tags

e97f02e

fix: folder tree icons

1063dbb

Merge branch 'main' into feat/tags

3f696e9

navigate to tag from detail panel

7d83bed

delete tag

63116ee

Tag position and add tag button

d036373

Tag asset in detail panel

fc12188

refactor form

c9ef63c

feat: navigate to tag page from clicking on a tag

10a242e

feat: delete tags from the tag page

b4b9749

refactor: moving tag section in detail panel and add + tag button

1aab452

feat: tag asset action in detail panel

ae513ca

refactor add tag form

1b4d8b5

Merge branch 'feat/tags' of github.com:immich-app/immich into feat/tags

2235461

fdisable add tag button when there is no selection

423b99e

feat: tag bulk endpoint

4b7cc76

feat: tag colors

42719af

chore: clean up

45302fd

chore: unit tests

de0ad6f

jrasm91 force-pushed the feat/tags branch from 011150b to de0ad6f Compare August 27, 2024 19:04

jrasm91 and others added 4 commits August 27, 2024 15:53

feat: write tags to sidecar

94721b3

Remove tag and auto focus on tag creation form opened

fb9cacd

Merge branch 'feat/tags' of github.com:immich-app/immich into feat/tags

0a0d15b

chore: regenerate migration

8ae0bf6

jrasm91 force-pushed the feat/tags branch from bea276e to 8ae0bf6 Compare August 27, 2024 20:55

jrasm91 and others added 4 commits August 27, 2024 16:55

chore: linting

2389346

add color picker to tag edit form

1bbdc13

Merge branch 'main' of github.com:immich-app/immich into feat/tags

c5155b1

fix: force render tags timeline on navigating back from asset viewer

ac91d87

alextran1502 approved these changes Aug 28, 2024

View reviewed changes

jrasm91 marked this pull request as ready for review August 28, 2024 21:30

jrasm91 requested a review from danieldietzler as a code owner August 28, 2024 21:30

danieldietzler reviewed Aug 28, 2024

View reviewed changes

jrasm91 added 2 commits August 29, 2024 10:36

feat: read tags from keywords

8bba334

chore: clean up

71a9c20

jrasm91 force-pushed the feat/tags branch from 03480e8 to 71a9c20 Compare August 29, 2024 16:00

jrasm91 merged commit d08a20b into main Aug 29, 2024
24 checks passed

jrasm91 deleted the feat/tags branch August 29, 2024 16:14

danieldietzler reviewed Aug 29, 2024

View reviewed changes

bo0tzz mentioned this pull request Sep 4, 2024

Future optimisations #4539

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: tags #11980

feat: tags #11980

jrasm91 commented Aug 22, 2024 •

edited

Loading

bo0tzz commented Aug 22, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as off-topic.

jrasm91 commented Aug 23, 2024

waclaw66 commented Aug 29, 2024

alextran1502 commented Aug 29, 2024

danieldietzler left a comment

ilyaChuk commented Aug 30, 2024

Knuppel1983 commented Oct 7, 2024

danieldietzler commented Oct 7, 2024

Knuppel1983 commented Oct 7, 2024

jrasm91 commented Oct 7, 2024

feat: tags #11980

feat: tags #11980

Conversation

jrasm91 commented Aug 22, 2024 • edited Loading

Add support for tags

bo0tzz commented Aug 22, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as off-topic.

jrasm91 commented Aug 23, 2024

waclaw66 commented Aug 29, 2024

alextran1502 commented Aug 29, 2024

danieldietzler left a comment

Choose a reason for hiding this comment

ilyaChuk commented Aug 30, 2024

Knuppel1983 commented Oct 7, 2024

danieldietzler commented Oct 7, 2024

Knuppel1983 commented Oct 7, 2024

jrasm91 commented Oct 7, 2024

jrasm91 commented Aug 22, 2024 •

edited

Loading