Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): Add Partner Sharing Avatars to Timeline and Info Cards #12089

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

x24git
Copy link
Contributor

@x24git x24git commented Aug 27, 2024

This Feature adds user avatars to the timeline for both partner sharing, and shared albums. The avatar uses the user's avatar image (if one is set) or the server's information is used to make an avatar using the user's assigned color and first letter of their name.
(In the screenshot below, the partner's icon is an Orange 'T')

This is an optional configuration that adds a new setting in the Photo Grid section of the settings.

Additionally, storage information is now shown in the image details card. For partner sharing it will show which partner it belongs to. For other images, it provides a text description and existing storage icons if the photo is local, remote, or merged (backed up). This can be useful if the storage icons are hidden.

@x24git x24git changed the title feat(mobile) Add Partner Sharing Avatars to Timeline and Info Cards feat(mobile): Add Partner Sharing Avatars to Timeline and Info Cards Aug 27, 2024
@x24git
Copy link
Contributor Author

x24git commented Aug 27, 2024

I am working on implementing a similar feature set on the web app to ensure consistent experience

@aviv926
Copy link
Contributor

aviv926 commented Aug 28, 2024

Implements
#7608 (actually for the web but the original PR publisher writes that he will consider a web version)

@x24git
Copy link
Contributor Author

x24git commented Aug 28, 2024

aviv926

Yeah, the plan was to put mobile and web together in one PR but ran into some issues getting it done efficiently on the web side, so I split the work. Should have the web implementation done shortly, and that would implement #7608 almost exactly like you mocked it up.

@x24git x24git marked this pull request as draft August 29, 2024 00:30
@x24git x24git marked this pull request as ready for review August 29, 2024 00:30
@x24git
Copy link
Contributor Author

x24git commented Sep 6, 2024

Cleaned up commit history and rebased to main, resolving merge conflicts.

@x24git
Copy link
Contributor Author

x24git commented Sep 6, 2024

PR #12413 implements the same feature set on web.

@scrampker
Copy link

Just curious, but is this feature still not available? I haven't seen any indication of who uploaded what to a shared album. Would be a nice addition. :)

Add settings option to show user icons on timeline

Hide icons from partner image grid

Replace with translatable text

Remove partner sharing references in shared albums

Minor improvements to phrasing in detail view
@x24git
Copy link
Contributor Author

x24git commented Oct 16, 2024

Just curious, but is this feature still not available? I haven't seen any indication of who uploaded what to a shared album. Would be a nice addition. :)

@scrampker Just updated the PR to incorporate the changes made in the mobile app as of 1.18. Should be good to merge (pending review).

Just need a maintainer to tag it and then review it :)

 - Use version that renders user's background theme and cached avatar
@alextran1502
Copy link
Contributor

alextran1502 commented Oct 18, 2024

Hello, thank you for the PR. I just ran testing on this PR. A few points

  • Turn off "Show user thumbnails" in the App Settings doesn't take effect.
  • I would like to have this mechanism disabled by default. Actually, having it on by default is nice.
  • In the asset viewer, putting the users' avatar on the top app bar looks strange. I think having the information inside the detail panel is enough

@x24git
Copy link
Contributor Author

x24git commented Oct 18, 2024

Hello, thank you for the PR. I just ran testing on this PR. A few points

  • Turn off "Show user thumbnails" in the App Settings doesn't take effect.
  • I would like to have this mechanism disabled by default. Actually, having it on by default is nice.
  • In the asset viewer, putting the users' avatar on the top app bar looks strange. I think having the information inside the detail panel is enough

Nice catch on the settings issue, and I do agree user avatar at the top is a bit out of place (since everything else up there is an action). I think there is enough context clues (like missing download and favorite icons) to indicate if an image is being shared.

@scrampker

This comment was marked as off-topic.

@bo0tzz
Copy link
Member

bo0tzz commented Oct 19, 2024

@scrampker that's entirely unrelated to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants