feat(server): parse offset from "Image_UTC_Data" (Samsung) #13080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Samsung phone might provide the local time (e.g. 09:00) without any timezone or offset information. If the file also includes the non-standard trailer tag "TimeStamp" in "Image_UTC_Data", we can use the unix timestamp contained within to deduce the offset. As an example, if the local date/time is "2024-09-15T09:00" and the unix timestamp is 1726408800 (which is 2024-09-15T16:00 UTC), we know that the offset is -07:00. The actual computation/fix is done in exiftool-vendored. Also see https://github.com/exiftool/exiftool/blob/0f63a780906abcccba796761fc2e66a0737e2f16/lib/Image/ExifTool/Samsung.pm#L996-L1001 photostructure/exiftool-vendored.js#209
1 task
danieldietzler
approved these changes
Oct 1, 2024
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Oct 3, 2024
…p#13080) * fix(deps): update dependency exiftool-vendored to v28.3.0 * feat(server): parse offset from "Image_UTC_Data" (Samsung) A Samsung phone might provide the local time (e.g. 09:00) without any timezone or offset information. If the file also includes the non-standard trailer tag "TimeStamp" in "Image_UTC_Data", we can use the unix timestamp contained within to deduce the offset. As an example, if the local date/time is "2024-09-15T09:00" and the unix timestamp is 1726408800 (which is 2024-09-15T16:00 UTC), we know that the offset is -07:00. The actual computation/fix is done in exiftool-vendored. Also see https://github.com/exiftool/exiftool/blob/0f63a780906abcccba796761fc2e66a0737e2f16/lib/Image/ExifTool/Samsung.pm#L996-L1001 photostructure/exiftool-vendored.js#209 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Samsung phone might provide the local time (e.g. 09:00) without any timezone or
offset information. If the file also includes the non-standard trailer tag
"TimeStamp" in "Image_UTC_Data", we can use the unix timestamp contained within to
deduce the offset.
As an example, if the local date/time is "2024-09-15T09:00" and the unix timestamp is
1726408800 (which is 2024-09-15T16:00 UTC), we know that the offset is -07:00.
The actual computation/fix is done in exiftool-vendored.
Also see
https://github.com/exiftool/exiftool/blob/0f63a780906abcccba796761fc2e66a0737e2f16/lib/Image/ExifTool/Samsung.pm#L996-L1001
photostructure/exiftool-vendored.js#209