-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): wrong image dimensions for RAW files (RAF, CR2, DNG) (also fixes face preview) #13377
Draft
C-Otto
wants to merge
1
commit into
main
Choose a base branch
from
raw-dimensions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Label error. Requires exactly 1 of: changelog:.*. Found: 🗄️server |
C-Otto
force-pushed
the
raw-dimensions
branch
2 times, most recently
from
October 11, 2024 15:49
7cf1c59
to
cca0135
Compare
3 tasks
mertalev
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just made a few suggestions to make it more idiomatic.
I'll have a look at your suggestions, thanks. While other weird RAW formats keep popping up, I'm pausing work on this (see discussion in #13049). |
C-Otto
force-pushed
the
raw-dimensions
branch
3 times, most recently
from
October 13, 2024 19:05
deeb445
to
96eec57
Compare
mertalev
reviewed
Oct 14, 2024
C-Otto
force-pushed
the
raw-dimensions
branch
from
October 15, 2024 06:40
cc6ac7a
to
7722769
Compare
C-Otto
changed the title
fix(server): prefer ImageSize over ImageWidth/Height metadata
fix(server): wrong image dimensions for RAW files (RAF, CR2, DNG) (also fixes face preview)
Oct 15, 2024
C-Otto
force-pushed
the
raw-dimensions
branch
from
October 15, 2024 06:44
7722769
to
f318772
Compare
For some RAW formats/cameras, the ImageWidth/ImageHeight information represents the dimensions of the preview image, i.e. much smaller than the actual image. This also causes issues with (face/people) thumbnail generation. The information in ImageSize seems to be correct, so we use this instead. fixes #13049 Add Fujifilm X100v RAW File (#12) Added Fujifilm X100v RAF RAW File
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some RAW formats/cameras, the ImageWidth/ImageHeight information represents the dimensions of the preview image, i.e. much smaller than the actual image. This also causes issues with (face/people) thumbnail generation. The information in ImageSize seems to be correct, so we use this instead.
fixes #13049