Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move weblate translations to root directory #13604

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ben-basten
Copy link
Member

@ben-basten ben-basten commented Oct 19, 2024

Description

Move the Weblate translations into the root directory of the repository. This starts setting the groundwork for mobile and web to share the same translations.

Moving the translation JSON files is in its own commit, in case any changes are needed.

How Has This Been Tested?

  • All PR checks are passing
  • Check that immich-server runs as expected when using the immich-server:pr-13604 image
  • Dev server for web works, using make dev and make dev-update

@ben-basten ben-basten marked this pull request as ready for review October 21, 2024 00:42
@ben-basten
Copy link
Member Author

A couple of open questions:

  • Are JSON files with ICU message formatting the desired direction for mobile?
  • Should country codes be added to the translation files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant