Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added description to generated sample excel file (#786) #803

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

Sidd-77
Copy link
Contributor

@Sidd-77 Sidd-77 commented Sep 20, 2024

Description

This PR addresses issue #786 by adding a description section to the generated sample Excel file. To achieve this, the following changes were made:

  • Integrated the @eyeseetea/xlsx-populate library to enhance Excel file manipulation and generation.
  • Created a backup of the existing implementation as old-file.service.ts to preserve the previous approach for reference and rollback purposes.

Changes Made

  • Added a description section to the generated Excel files for better clarity and usability.
  • Updated the file generation process using @eyeseetea/xlsx-populate for improved performance and functionality.
  • Maintained the old implementation separately in old-file.service.ts for legacy support.

Testing

  • Verified that the new description appears correctly in the generated Excel file.
  • Ensured that the backup file (old-file.service.ts) remains functional if needed.

Related Issue

Copy link

nx-cloud bot commented Sep 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f7dc5e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Description in Generated Sample Excel File
1 participant