Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no internal modules with exports #1691

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Update no internal modules with exports #1691

merged 1 commit into from
Jun 2, 2020

Conversation

adjerbetian
Copy link

@adjerbetian adjerbetian commented Mar 22, 2020

Resolves #1481

About the breaking change

In the ticket it was suggested to add an option for this behavior. Do you still want this rule behind an option? This behavior with the export feels so natural to me that I would feel strange if it wasn't the default behavior.

Changelog

I update the documentation, but I didn't know how to update the changelog. I wouldn't be against some guidance or help here 😊.

Step down rule

I hesitated to clean the code in /src/rules/no-internal-modules.js to use the step down rule, but I don't want to impose my tastes on this. Do you want me to do it?

@coveralls
Copy link

coveralls commented Mar 22, 2020

Coverage Status

Coverage increased (+0.002%) to 97.739% when pulling 9dfef28 on adjerbetian:update-no-internal-modules-with-exports into 6dd28ea on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

@adjerbetian

This comment has been minimized.

@adjerbetian
Copy link
Author

@ljharb Can you give me your opinion on this?

@ljharb
Copy link
Member

ljharb commented Jun 2, 2020

I agree; this feels like a bugfix.

@ljharb ljharb merged commit 9dfef28 into import-js:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

No internal module export
3 participants