Added abort signal to fetch transport #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
approved these changes
Apr 21, 2018
| @@ -44,12 +45,13 @@ class Fetch implements Transport { | |||
| }); | |||
| } | |||
|
|
|||
| send(msgBytes: ArrayBufferView) { | |||
| send(msgBytes: Uint8Array) { | |||
There was a problem hiding this comment.
This makes sense as fetch now only accepts Uint8Array and not ArrayBufferView. Can you replace ArrayBufferView with Uint8Array across the codebase in this change please?
runarheggset
force-pushed
the
master
branch
3 times, most recently
from
f1a239c
to
97819cc
Compare
runarheggset
force-pushed
the
master
branch
2 times, most recently
from
767ae30
to
9616d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added abort signal to fetch transport so that we can cancel requests before any data is sent/received.
Chrome support for AbortController is coming in version 66.