Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export a UMD Module #276

Merged
merged 3 commits into from
Nov 11, 2018
Merged

Export a UMD Module #276

merged 3 commits into from
Nov 11, 2018

Conversation

Dig-Doug
Copy link
Contributor

@Dig-Doug Dig-Doug commented Nov 6, 2018

Originally #273, I thought it would be easier to start fresh instead of trying to fix a bad rebase.

jonnyreeves
jonnyreeves reviewed Nov 7, 2018
View reviewed changes
Copy link
Contributor

@jonnyreeves jonnyreeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing, just one outstanding question about a new dependency.

client/grpc-web-client/package.json Outdated Show resolved Hide resolved
jonny-improbable
jonny-improbable approved these changes Nov 11, 2018
View reviewed changes
Copy link
Contributor

@jonny-improbable jonny-improbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonny-improbable jonny-improbable merged commit 3d7e106 into improbable-eng:master Nov 11, 2018
@Dig-Doug Dig-Doug mentioned this pull request Nov 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyreeves jonnyreeves jonnyreeves left review comments

@jonny-improbable jonny-improbable jonny-improbable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dig-Doug @jonnyreeves @jonny-improbable