Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend_backoff_max_delay flag to grpcwebproxy #278

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Add backend_backoff_max_delay flag to grpcwebproxy #278

merged 2 commits into from
Nov 8, 2018

Conversation

fordhurley
Copy link
Contributor

Closes #277.

johanbrandhorst
johanbrandhorst suggested changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! Just a tiny nit pick (I need to justify my existence, right?)

go/grpcwebproxy/backend.go Outdated
opt = append(opt, grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(*flagMaxCallRecvMsgSize)))
opt = append(opt, grpc.WithBackoffMaxDelay(*flagBackendBackoffMaxDelay))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two can just go in the same append call:

opt = append(opt,
     grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(*flagMaxCallRecvMsgSize)),
     grpc.WithBackoffMaxDelay(*flagBackendBackoffMaxDelay),
)

@johanbrandhorst
Copy link
Contributor

Nice work! I'll merge it after the tests have passed.

@johanbrandhorst
Copy link
Contributor

Rerunning the failed tests in case they were flakes.

@johanbrandhorst johanbrandhorst merged commit fdebee8 into improbable-eng:master Nov 8, 2018
@johanbrandhorst
Copy link
Contributor

Thanks for your contribution!

@fordhurley
Copy link
Contributor Author

Awesome! Thank you!

@fordhurley fordhurley deleted the backoff-max-delay branch November 8, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fordhurley @johanbrandhorst