Support client certs for backend connections #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 3 flags to grpcwebproxy to support gRPC backend which require TLS client auth. Signed-off-by: mastersingh24 <[email protected]>
mastersingh24
changed the title
johanbrandhorst
suggested changes
Feb 6, 2019
Simplify logic by checking both flagBackendTlsClientCert and flagBackendTlsClientKey are set Signed-off-by: mastersingh24 <[email protected]>
johanbrandhorst
approved these changes
Feb 7, 2019
|
LGTM let's wait for the build to finish |
|
I've restarted the failing tests, this change shouldn't be causing any test failures 🤔 |
|
Round 3, GO! |
|
Thanks for your contribution! |
|
Cool. Thanks. And thanks for this project overall ... very cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 flags to grpcwebproxy to support gRPC
backend which requires TLS client auth.
Fixes #332
Signed-off-by: mastersingh24 [email protected]