Cabol.3.cowboy swagger handler #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cabol
commented
Aug 6, 2015
cabol
commented
- Issue Implement GET method in 'swagger_handler' in order to retrieve the JSON specification (swagger.json) #3 solved.
- Fixed Makefile to fetch latest trails release (0.0.2).
| -spec all(atom()) -> [atom()]. | ||
| all(Module) -> | ||
| ExcludedFuns = [module_info, init_per_suite, end_per_suite, group, all], | ||
| Exports = Module:module_info(exports), |
There was a problem hiding this comment.
According to Elvis:
Remove the dynamic function call on line 18. Only modules that define callbacks should make dynamic calls.
There was a problem hiding this comment.
According to Elvis:
Remove the dynamic function call on line 18. Only modules that define callbacks should make dynamic calls.
| {http_listener_count, 10} | ||
| ] | ||
| } | ||
| ]. |
There was a problem hiding this comment.
I think because that EOF gadget/dialyzer is complaining.
|
|
||
| %% cowboy | ||
| allowed_methods(Req, State) -> | ||
| {[<<"GET">>, <<"PUT">>, <<"HEAD">>], Req, State}. |
davecaos
pushed a commit
that referenced
this pull request
Aug 11, 2015
elbrujohalcon
pushed a commit
that referenced
this pull request
Aug 11, 2015
Cabol.3.cowboy swagger handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.