Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle openapi 3.0 format, use new swagger-ui #114

Merged
merged 7 commits into from
Jun 4, 2019

Conversation

szlartibartfaszt79
Copy link
Contributor

  • handle openapi 3.0 format
  • copy latest swagger-ui
  • remove default swagger config parameter for openapi config parameter using

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but… don't we need to update/create some tests for this change?

@szlartibartfaszt79
Copy link
Contributor Author

I like this, but… don't we need to update/create some tests for this change?

You're right. I fixed the failed test, but I have to extend the test cases with openapi 3.0 format.

@szlartibartfaszt79
Copy link
Contributor Author

WIP

@szlartibartfaszt79
Copy link
Contributor Author

Need I squash before merge?
There were two minor fixes after approval. This version is used internally for half year without any issues.

@elbrujohalcon elbrujohalcon merged commit 8c7b831 into inaka:master Jun 4, 2019
@elbrujohalcon
Copy link
Member

Merged. Thanks @szlartibartfaszt79 :)

@szlartibartfaszt79 szlartibartfaszt79 deleted the swagger_3 branch June 4, 2019 13:24
@szlartibartfaszt79
Copy link
Contributor Author

Thanks for the merge :-)
Unfortunately README.md is not up-to-date according to openapi specification. Moreover it contains some wrong data, for example: swagger => "2.0". It will be fixed as soon as possible in a new PR. I apologize for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants