Exit better than throw #71
Conversation
| catch | ||
| _:Error -> | ||
| lager:error("Error here: ~p~n" | ||
| " Arguments: ~p~n" | ||
| " Stack: ~p", [Error, WithThis, erlang:get_stacktrace()]), | ||
| {error, Error} | ||
| end. | ||
|
|
||
| good2(WithThis) -> |
There was a problem hiding this comment.
According to Xref:
loud_errors:good2/1calls undefined functionsomething:that/3
| throw({error, Error}) | ||
| end. | ||
|
|
||
| good1(WithThis) -> |
There was a problem hiding this comment.
According to Xref:
loud_errors:good1/1calls undefined functionlager:error/2
|
|
||
| bad(WithThis) -> | ||
| bad1(WithThis) -> |
There was a problem hiding this comment.
According to Xref:
loud_errors:bad1/1calls undefined functionsomething:that/3
| try | ||
| something:that(may, fail, WithThis) | ||
| catch | ||
| _:Error -> | ||
| {error, Error} | ||
| end. | ||
|
|
||
| good(WithThis) -> | ||
| bad2(WithThis) -> |
There was a problem hiding this comment.
According to Xref:
loud_errors:bad2/1calls undefined functionsomething:that/3
| throw({error, Error}) | ||
| end. | ||
|
|
||
| good1(WithThis) -> |
There was a problem hiding this comment.
According to Xref:
loud_errors:good1/1calls undefined functionsomething:that/3
|
I propose this as I plan to replace several Feel feel to close straight away if you feed exit not to be good enough. |
Depends on PR #70.
Before merging this PR, go over this checklist: