[#30] dialyzer warnings fixed #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
requested changes
Jun 6, 2017
src/sumo_store_riak.erl
Outdated
| @@ -38,6 +38,10 @@ | |||
|
|
|||
| -include_lib("riakc/include/riakc.hrl"). | |||
|
|
|||
| %% @todo it is needed with basho/riak-erlang-client 2.5.3. They already fixed on master so we should | |||
There was a problem hiding this comment.
TODOs should start with a verb, like:
%% @todo remove this when riakc … etc. etc.The explanation can go below that line.
ferigis
force-pushed
the
ferigis.30.fix_tests
branch
from
267318a
to
6ee336f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[close #30]