DRY Explore containers #1999
Open
DRY Explore containers #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRY up Explore container logic so most of it is just in one place, and just the parts that differ between Root and Stacked contexts are specified in their own containers.
There was a problem hiding this comment.
I didn't get this code to run (bumping into some XCode signing issues specifically on this branch, maybe because we're using different signing provisions?), but the code looks good and I like the simplicity of this approach and having less confusing duplication of code.
|
@albullington weird, nothing should have changed with signing. Did you try running from xcode and not using the commandline react native tools? Either way, we can revisit next week after soft launch. Nothing here is critical for functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RootExploreContainer and ExploreContainer were basically duplicates with minor tweaks, which was frustrating when you needed to change something in both, and as a result they were starting to drift. This PR unifies all of the logic they share into ExploreContainer and separates the ways in which they differ into RootExploreContainer and StackedExploreContainer.