fix: hide Wikipedia button if server provides no Wikipedia URL #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kueda
changed the title
kueda
requested changes
Sep 17, 2024
There was a problem hiding this comment.
The example of Strangalia acuminata in the issue is really a server-side problem. IMO, we should do what the issue requested and hide the link if the server didn't provide wikipedia_url, because in theory it's the server's responsibility to provide a valid Wikipedia URL, and if it doesn't, the client should just assume there's a good reason for that.
So,
- Hide the Wikipedia button if the server didn't provide
wikipedia_url, or if it did and it was blank - Remove that vestigial code constructing the Wikipedia URL from the taxon name
kueda
changed the title
…provided Wikipedia URL
kueda
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1740