Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force refresh of home screen when drawer is opened/closed #2093

Closed
wants to merge 3 commits into from

Conversation

budowski
Copy link
Collaborator

@budowski budowski commented Sep 17, 2024

Closes #1886

@kueda kueda changed the title Fix #1886 - force refresh of home screen when drawer is opened/closed Force refresh of home screen when drawer is opened/closed Sep 17, 2024
Copy link
Member

@kueda kueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a different solution here. Add useDrawerStatus() to MyObsContainer causes MyObs to rerender every time the user opens the drawer, adding a lag to the appearance of the drawer.

I think you need to figure out why MyObs is rerendering when a user w/ observations signs out but not when a user without observations signs out and work from there. I would also expect useCurrentUser( ) to return a different value and trigger a re-render when the user signs out, so that might be another way to come at this.

Copy link
Member

@kueda kueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drawer is much more responsive now and the signout bug is not happening, but have you have some failing tests.

@kueda kueda self-assigned this Oct 22, 2024
@kueda
Copy link
Member

kueda commented Nov 7, 2024

App restart on sign out added in #2294 makes this unnecessary, I think.

@kueda kueda closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Signing out of an account with 0 observations doesn't always work properly
2 participants