Deprecate get_mvb_term()
#88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #60 (comment) |
- Use reference data as default (smaller to download) - Don't check for existence of file (snapshot does that) - Don't check for doi (is frictionless) - Add reference data, then gps
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 87.98% 97.93% +9.95%
==========================================
Files 10 10
Lines 566 582 +16
==========================================
+ Hits 498 570 +72
+ Misses 68 12 -56 ☔ View full report in Codecov by Sentry. |
peterdesmet
force-pushed
the
deprecate_mvb_term
branch
from
f5e6298
to
ce17b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #85
fix #60
The new (not-accepted) snapshot is different from the previous snapshot because of a different way to handle attributes that have been merged.
move2::movebank_get_vocabularyreturns the updated name, whileget_mvb_term()returns the original term with the message "This attribute has been merged with 'x'."There are 3 case studies: