Merged IndexPoolMeta and PoolUpdateRecord structs and fixed references to them. Resolves #5 #7 #10 #13 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the way they were used. | Resolves #5 #7 #10 #13 Made all of these changes as a single PR since they are related to the use of the structs which were modified. Fixed erroneous typecast to uint8 for categoryID in . #5 Merged IndexPoolMeta and PoolUpdateRecord into a single struct. #13 Replaced function with modifier of the same name. Replaced references in all functions that used it except for , which already has access to the struct. #7 Set pool's last reweigh timestamp in #10 Modified order of execution to apply storage updates to meta prior to calling reweigh and reindex. This is unlikely to be an issue due to the fact that the pool is always an approved implementation, but there's no efficiency impact so to stay on the safe side I switched the order.
As mentioned in a suggestion from @cleanunicorn, it is worthwhile to explain why the struct fields have the sizes they do.
d1ll0n
added
bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made all of these changes as a single PR since they are related to the use of the structs which were modified.
Merged IndexPoolMeta and PoolUpdateRecord into a single struct. (resolves #13)
Fixed erroneous typecast to uint8 for
categoryIDinprepareIndexPool. (resolves #5)Replaced
_havePoolfunction with modifier of the same name. Replaced references in all functions that used it except forreweighPool, which already has access to the struct. (resolves #7)Set pool's last reweigh timestamp in
finishPreparedIndexPool(resolves #10)Modified order of execution to apply storage updates to meta prior to calling reweigh and reindex. This is unlikely to be an issue due to the fact that the pool is always an approved implementation, but there's no efficiency impact so to stay on the safe side I switched the order.
Added explanation of IndexPoolMeta struct field sizes. As mentioned in a suggestion from @cleanunicorn, it is worthwhile to explain why the struct fields have the sizes they do.