Update ActiveRelationTrait.php

Fix for PHP 7.4 Trying to access array offset on value of type null When: if (($value = $model[$attribute]) !== null) /var/www/builds/cms/3.6.0/vendor/yiisoft/yii2/db/ActiveRelationTrait.php line 526 #0 /var/www/builds/cms/3.6.0/vendor/yiisoft/yii2/db/ActiveRelationTrait.php(526): yii\base\ErrorHandler->handleError() yiisoft#1 /var/www/builds/cms/3.6.0/vendor/yiisoft/yii2/db/ActiveRelationTrait.php(246): yii\db\ActiveQuery->filterByModels() yiisoft#2 /var/www/builds/cms/3.6.0/vendor/yiisoft/yii2/db/ActiveQueryTrait.php(151): yii\db\ActiveQuery->populateRelation() yiisoft#3 /var/www/builds/cms/3.6.0/vendor/yiisoft/yii2/db/ActiveQuery.php(224): yii\db\ActiveQuery->findWith()
indrig · Dec 26, 2019 · 2fe06b6 · 2fe06b6
1 parent 573fd5f
commit 2fe06b6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/db/ActiveRelationTrait.php b/db/ActiveRelationTrait.php
@@ -523,7 +523,8 @@ private function filterByModels($models)
             // single key
             $attribute = reset($this->link);
             foreach ($models as $model) {
-                if (($value = $model[$attribute]) !== null) {
+                if ($model !== null) {
+                    $value = $model[$attribute];
                     if (is_array($value)) {
                         $values = array_merge($values, $value);
                     } elseif ($value instanceof ArrayExpression && $value->getDimension() === 1) {