Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails when using ccache in CC environment variable #178

Closed
dbnicholson opened this issue Jul 21, 2022 · 0 comments
Closed

Build fails when using ccache in CC environment variable #178

dbnicholson opened this issue Jul 21, 2022 · 0 comments

Comments

@dbnicholson
Copy link
Contributor

make_cffi.py assumes the first argument of the distutils compiler will work as the preprocessor. That fails when using ccache by prepending it in the CC environment variable like CC="ccache gcc". This is a regression from 0d1329a.
dbnicholson added a commit to dbnicholson/python-zstandard that referenced this issue Jul 21, 2022
@dbnicholson
cffi: Use the distutils preprocessor when available
ccb555d 
On Unix like systems, distutils will usually set the preprocessor
attribute to the appropriate command. On MSVC it never sets the
preprocessor, though. In either case, try to use it and only fallback to
using the compiler if needed. Using compiler.compiler[0] breaks use of
ccache when inserted in the CC environment variable.

This is a regression from 0d1329a.

Closes indygreg#178.
@dbnicholson dbnicholson mentioned this issue Jul 21, 2022
Closed
indygreg pushed a commit that referenced this issue Oct 29, 2022
@dbnicholson @indygreg
cffi: Use the distutils preprocessor when available
0388bb7 
On Unix like systems, distutils will usually set the preprocessor
attribute to the appropriate command. On MSVC it never sets the
preprocessor, though. In either case, try to use it and only fallback to
using the compiler if needed. Using compiler.compiler[0] breaks use of
ccache when inserted in the CC environment variable.

This is a regression from 0d1329a.

Closes #178.
Closes #179.
indygreg pushed a commit that referenced this issue Oct 29, 2022
@dbnicholson @indygreg
cffi: Use the distutils preprocessor when available
5ca5ce8 
On Unix like systems, distutils will usually set the preprocessor
attribute to the appropriate command. On MSVC it never sets the
preprocessor, though. In either case, try to use it and only fallback to
using the compiler if needed. Using compiler.compiler[0] breaks use of
ccache when inserted in the CC environment variable.

This is a regression from 0d1329a.

Closes #178.
Closes #179.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cffi: Use the distutils preprocessor when available dbnicholson/python-zstandard
1 participant
@dbnicholson