[1.x] Fix [scroll-region] on html element with overflow-scroll #1782
Conversation
…. use this.page instead of page
There was a problem hiding this comment.
Tested this PR on the React and Vue3 playground following the steps to reproduce from #1211. The proposed solution fixes that issue 👍
There's another issue that prevents your solution from working in React projects but #1803 already takes care of that. I tested the code from both PRs to confirm they fully fix the issue 🙌
My only suggestion is move this.restoreScrollPositions() to outside of the else block, between if statements is fine 😉
Thanks @axel-paillaud!
pedroborges
changed the title
There was a problem hiding this comment.
Thank you!
I tested this out on the playground and was able to replicate both the problem and the fix. Just flagging that it feels a bit odd that page and this.page are out of sync in this way, but the fix works and I don't see any side effects, so we'll just keep an eye on it.
|
You're welcome ! Glad to help. |
* master: (95 commits) [1.x] Fix props reactivity (inertiajs#1969) [1.x] useForm wrongly overwrites default values after successful submission (inertiajs#1935) Update changelog [1.x] Fix `resetScrollPositions` and `restoreScrollPositions` router methods (inertiajs#1980) [1.x] Fix [scroll-region] on html element with overflow-scroll (inertiajs#1782) [1.x] Fix useForm re-renders by memoizing functions in React (inertiajs#1607) [1.x] Fix "DataCloneError: <Object> could not be cloned" (inertiajs#1967) [1.x] preserveScroll should be true on initial page visit (inertiajs#1360) Fix type augmentation (inertiajs#1958) [1.x] Fix doubling hash in React StrictMode (inertiajs#1728) [1.x] Add SSR support for Svelte 5 (inertiajs#1970) [1.x] Fix <Render /> component to respect "preserveState" (inertiajs#1943) [1.x] Fix 'received an unexpected slot "default"' warning (inertiajs#1941) QA: Add @types/lodash to fix svelte-check QA: Update reactive if statement Review useForm types QA: Move the if server up QA: Revert tsconfig change QA: Remove plural QA: Remove unused props type + add extra types just in case ... # Conflicts: # packages/react/src/index.ts
add
restoreScrollPositions()insetPage()method if we have scroll-region. Usethis.pageinstead ofpage.This is related to #1211
In line 454 :
console.log(page.scrollRegions)is always undefined, and I don't know why.If we do only
console.log(page), we can see the scrollRegions field inside browser inspector, but I think it was populated asynchronously ?With this version,
scroll-regionwork well, and scrolling items are not reset when we submit the form (for example), butthis.pageis kind of a cheat ?