Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of terminal commands #5

Open
jeremyVignelles opened this issue Oct 11, 2024 · 0 comments · May be fixed by #6
Open

Allow customization of terminal commands #5

jeremyVignelles opened this issue Oct 11, 2024 · 0 comments · May be fixed by #6

Comments

@jeremyVignelles
Copy link
Contributor

These lines are hardcoded:

devbox-scripts/openWt.mjs

Lines 103 to 106 in a5f3952

const term1Command = `ssh ${devboxSsh} -t "sleep 3\\;cd /home/vagrant/projects/${relativeProjectPath}\\; bash --login"` // sleep 3: smartcd supporte mal d'être lancé deux fois en parallèle...
const term2Command = `ssh ${devboxSsh} -t "cd /home/vagrant/projects/${relativeProjectPath}\\; bash --login"`
const term3Command = `node mutagenStart.mjs ${path.basename(projectPath)}`
const term4Command = `ssh ${devboxSsh} -t "sleep 6\\;cd /home/vagrant/projects/${relativeProjectPath}\\; bash --login"` // sleep 6: smartcd supporte mal d'être lancé deux fois en parallèle... Alors 3 fois...

It would be nice to expose, from the variables.default.mjs, a single method that gets the terminal commands to run.
It should take as params the command line parameters, and info about the devbox, and return an array of commands to run.

This way, the configuration could be overriden by the variables.mjs file

jeremyVignelles added a commit that referenced this issue Oct 28, 2024
Created a windowsTerminalCommandsBuilder callback that can be overriden.
Also created a windowsTerminalLayoutBuilder callback.
Fixes #5.
@jeremyVignelles jeremyVignelles linked a pull request Oct 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant