fix(boilerplate): clean up mentions of index.js #2762
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindboe
reviewed
Oct 14, 2024
| @@ -31,6 +31,6 @@ | |||
| "module": "commonjs" | |||
| } | |||
| }, | |||
| "include": ["index.js", "App.tsx", "app", "types", "plugins", "app.config.ts"], | |||
| "include": ["App.tsx", "app", "types", "plugins", "app.config.ts"], | |||
There was a problem hiding this comment.
I think we've updated this since and this change doesn't apply anymore. Updating the file tree int he README does seem like a good idea, though, I think that's pretty out of date. @andrewsixsixsix would you like to update this PR? If not we can follow up on that.
There was a problem hiding this comment.
@lindboe Feel free to close it if the changes I made are not relevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
Cleans up mentions of
index.jsfile, as it is not part of Ignite v9 boilerplate