Add support for custom headers in AutoImage #2767
Open
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankcalise
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Thanks for this, left one comment.
Also, could you look into updating the documentation to match this change in https://github.com/infinitered/ignite/blob/master/docs/boilerplate/app/components/AutoImage.md?
Comment on lines
+13
to
+15
| headers?: { | ||
| [key: string]: string | ||
| } |
There was a problem hiding this comment.
Could you please document this to be consistent with the other props? Something mentioning that these are the headers for the request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
As the title, my project is currently using your boilerplate but AutoImage component is missing the feature, it would be great if the main repo supported it