Apply suggestions from code review

Co-authored-by: Ivan Ramljak <[email protected]>
Co-authored-by: Davorin Prislin <[email protected]>

CHANGELOG.md

@@ -8,7 +8,7 @@ This projects adheres to [Semantic Versioning](https://semver.org/) and [Keep a
 
 ### Added
 
-- New Integration for `Paycek payment`.
+- New Integration for `PayCek payment`.
 
 ## [5.2.0]
 

src/Blocks/custom/paycek/manifest.json

@@ -1,7 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/infinum/eightshift-frontend-libs/develop/schemas/block.json",
 	"blockName": "paycek",
-	"title": "Corvus form",
+	"title": "PayCek form",
 	"description" : "Corvus issues application form",
 	"category": "eightshift-forms",
 	"icon": {

src/Blocks/custom/paycek/paycek-overrides.js

@@ -4,7 +4,7 @@ import { getUtilsIcons } from '../../components/form/assets/state-init';
 
 export const overrides = {
 	...manifest,
-	icon:{
+	icon: {
 		src: getUtilsIcons('paycek') ?? manifest.icon.src,
 	},
 	attributes: {

src/Integrations/Paycek/SettingsPaycek.php

@@ -413,8 +413,7 @@ public function getSettingsGlobalData(): array
 								'stepsContent' => [
 									\__('Log in to your Paycek Merchant Account.', 'eightshift-forms'),
 									\__('Go to your Account.', 'eightshift-forms'),
-									\__('Go to "profile setting" and you will fin your Profile ID under "Code".', 'eightshift-forms'),
-									\__('Go to "profile setting" and you will fin your API Key under "Secret Key".', 'eightshift-forms'),
+									\__('Go to "profile setting" and you will find your Profile ID under "Code".', 'eightshift-forms'),
 								],
 							],
 							[
@@ -424,7 +423,7 @@ public function getSettingsGlobalData(): array
 									\__('Log in to your Paycek Merchant Account.', 'eightshift-forms'),
 									\__('Go to your Account.', 'eightshift-forms'),
 									\__('Go to "profile setting" and you will fin your Profile ID under "Code".', 'eightshift-forms'),
-									\__('Copy the Store ID into the field under the API tab or use the global constant.', 'eightshift-forms'),
+									\__('Copy the Profile ID into the field under the API tab or use the global constant.', 'eightshift-forms'),
 								],
 							],
 						],

src/Integrations/Workable/WorkableClient.php

@@ -306,7 +306,7 @@ public function getTestApi(): array
 	 *
 	 * @return array<string, mixed>
 	 */
-	private function getWorkableItems()
+	private function getWorkableItems(): array
 	{
 		$url = "{$this->getBaseUrl()}jobs?limit=1000&state=closed,published";
 

src/Labels/Labels.php

@@ -531,7 +531,7 @@ private function getPaycekLabels(): array
 		return [
 			'paycekMissingReqParams' => \__('This form is not configured correctly. Please get in touch with the website administrator to resolve this issue.', 'eightshift-forms'),
 			'paycekMissingConfig' => \__('This form is not configured correctly. Please get in touch with the website administrator to resolve this issue.', 'eightshift-forms'),
-			'paycekSuccess' => \__('Application submitted successfully. Thank you!', 'eightshift-forms'),
+			'paycekSuccess' => \__('Payment submitted successfully. Thank you!', 'eightshift-forms'),
 		];
 	}
 

src/Rest/Routes/Integrations/Paycek/FormSubmitPaycekRoute.php

@@ -61,7 +61,7 @@ public function __construct(
 	}
 
 	/**
-	 * Get the base url of the route
+	 * Get the base URL of the route.
 	 *
 	 * @return string The base URL for route you are adding.
 	 */
@@ -195,7 +195,7 @@ private function base64urlEncode(string $data): string
 	 *
 	 * @param string $profileCode can be found in profile settings (https://paycek.io).
 	 * @param string $secretKey can be found in profile settings (https://paycek.io).
-	 * @param string $paymentId unique payment id (id that you are using on your website to uniquely describe the purchase).
+	 * @param string $paymentId unique payment ID (ID that you are using on your website to uniquely describe the purchase).
 	 * @param string $totalAmount total price (example "100.00").
 	 * @param string $email email of your customer.
 	 * @param string $description payment description (max length 100 characters).