Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(iox-10577): patched df upgrade 202-04-05 #8

Closed
wants to merge 10 commits into from

Conversation

appletreeisyellow
Copy link

@appletreeisyellow appletreeisyellow commented Apr 22, 2024

⚠️ This will not be merged. ⚠️

This PR is based on #5 that including the following patches:

  1. Bringing us up to datafusion to 2024-04-05

  2. PATCH: add the named struct patch

    commit 66f4fcb4664fc797ffb046d5b2ebcfca65ba4cd7
    Author: Andrew Lamb <[email protected]>
    Date:   Tue Apr 2 17:21:02 2024 -0400
    
        Use `struct` instead of `named_struct` when there are no aliases (#9897)
    
  3. PATCH: include the patch request (per slack) for the upstream coalesce bug.
    apache@4d85979 / coercion vec[Dictionary, Utf8] to Dictionary for coalesce function apache/datafusion#9958

    commit f0eec349a1abed14bcb2ee8a9fbf98bbb19b8f9a (HEAD -> iox-10350/df-upgrade-2024-03-31)
    Author: Lordworms <[email protected]>
    Date:   Fri Apr 5 15:57:48 2024 -0500
    
        coercion vec[Dictionary, Utf8] to Dictionary for coalesce function (#9958)
    
  4. PATCH: patch for the function re-writer, visiting subqueries within expressions.

    commit e8de1c612a986ae4b0348ce0a9d92f08d93c258c
    Author: Andrew Lamb <[email protected]>
    Date:   Wed Apr 10 11:14:02 2024 -0400
    
        fix NamedStructField should be rewritten in OperatorToFunction in subquery
    

alamb and others added 5 commits April 5, 2024 12:40
…che#9897)

* Revert "use alias (apache#9894)"

This reverts commit 9487ca0.

* Use `struct` instead of `named_struct` when there are no aliases

* Update docs

* fmt
…pache#9958)

* for debug

finish

remove print

add space

* fix clippy

* finish

* fix clippy
@appletreeisyellow appletreeisyellow changed the title WIP(iox-10577): patched df upgrade 202-04-TBD WIP(iox-10577): patched df upgrade 202-04-05 Apr 22, 2024
@appletreeisyellow
Copy link
Author

The upgrade is done. Closing

@appletreeisyellow appletreeisyellow deleted the chunchun/update-df-apr-week-1-2 branch April 29, 2024 16:40
appletreeisyellow added a commit that referenced this pull request May 24, 2024
…he#10527)

* chore: merge main and resolve conflict

* chore: use less copy

* chore: remove clone

* remove more clones (#8)

* refactor: use HashSet<&Expr> instead of HashSet<String>

* refactor: remove more cloning

* chore: reduce string allocation

Co-authored-by: Adam Curtis <[email protected]>

* chore: return internal error instead of panacing

* chore: use arg display_name as hash key instead of a hashed value

---------

Co-authored-by: Adam Curtis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants