Removed duplicated HOSTIP #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could someone take a look? It's just a fix to a duplicated arg. |
|
Could you please also file an issue and demonstrate how this duplication shows up? |
|
Just published the issue: |
|
@caiocfer thanks - can you update the version in your PR please? |
When this helm chart is deployed the HOSTIP env arg was duplicated in the daemonset. Signed-off-by: Caio Cesar Ferreira <[email protected]>
caiocfer
force-pushed
the
remove-hostip-duplication
branch
2 times, most recently
from
2333ae4
to
e3197f0
Compare
powersj
approved these changes
Oct 24, 2023
|
Just here to ask why the HOSTIP env var was removed from template but kept in the values file? Shouldn't be the other way around to keep the service working even if people uses some custom values? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When telegraf-ds helm chart is deployed the HOSTIP env arg is duplicated in the daemonset.