feat: add implicit batching to writeAPIBlocking #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlastahajek
force-pushed
the
feat/syncwrite_batching
branch
from
00fe7bf
to
a9c1e37
Compare
tomklapka
approved these changes
Aug 25, 2022
danielorbach
added a commit
to danielorbach/influxdb-client-go
that referenced
this pull request
Oct 19, 2022
Pull Request influxdata#350 (commit a9c1e37) introduced `Flush()` and `Write()` functions blindly returning the result of a `func (Service) WriteBatch(...) *http2.Error`. This causes the returned error to always evaluate as `non-nil`. Fixes influxdata#360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #336
Proposed Changes
Added support for implicit batching to
WriteAPIBlocking. It's off by default, enabled byEnableBatching().Checklist