Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): remove deprecated pkg/errors #386

Merged
merged 4 commits into from
Oct 12, 2023
Merged

chore(deps): remove deprecated pkg/errors #386

merged 4 commits into from
Oct 12, 2023

Conversation

andig
Copy link
Contributor

@andig andig commented Oct 1, 2023 •
edited
Loading

Signed-off-by: andig [email protected]

Proposed Changes

Remove deprecated pkg/errors. Depends on #387, needs rebase/tidy after #387 has been merged.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2c80fa5) 92.72% compared to head (168707a) 92.72%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files          23       23           
  Lines        2242     2242           
=======================================
  Hits         2079     2079           
  Misses        123      123           
  Partials       40       40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andig
Copy link
Contributor Author

andig commented Oct 1, 2023

Depends on #387

@andig andig changed the title Remove deprecated pkg/errors chore(deps): remove deprecated pkg/errors Oct 1, 2023
@andig andig mentioned this pull request Oct 2, 2023
Merged
6 tasks
@andig
Copy link
Contributor Author

andig commented Oct 7, 2023

Friendly ping- could this be considered for merging?

@andig andig marked this pull request as draft October 7, 2023 11:26
@bednar
Copy link
Contributor

bednar commented Oct 9, 2023

Hi @andig,

the #387 is merged.

Regards

@bednar bednar self-requested a review October 9, 2023 09:15
@andig andig marked this pull request as ready for review October 9, 2023 19:19
@andig
Copy link
Contributor Author

andig commented Oct 9, 2023

Thank you, rebased!

bednar
bednar requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 👍

Could you please update the CHANGELOG.md with a description of your changes?

@andig
Copy link
Contributor Author

andig commented Oct 11, 2023

Done

@bednar bednar merged commit fd16abc into influxdata:master Oct 12, 2023
1 check passed
@bednar bednar added this to the 2.12.4 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.4
Development

Successfully merging this pull request may close these issues.
3 participants
@andig @codecov-commenter @bednar