Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: url to connect to the InfluxDB is always evaluate as a connection string #335

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 14, 2022

Proposed Changes

The url to connect to the InfluxDB is always evaluate as a connection string. The following code correctly set timeout:

InfluxDBClient client = InfluxDBClientFactory.createV1("http://localhost:8086?writeTimeout=30000",
        "my-username",
        "my-password".toCharArray(),
        "database",
        "week");

Fixed flaky test: doNotPropagateErrorOnCanceledConsumer().

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar changed the title feat: the url to connect to the InfluxDB is always evaluate as a connection string feat: url to connect to the InfluxDB is always evaluate as a connection string Apr 14, 2022
@bednar bednar requested a review from rhajek April 14, 2022 06:56
@bednar bednar marked this pull request as ready for review April 14, 2022 06:56
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #335 (24575d1) into master (7b26209) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 24575d1 differs from pull request most recent head 06a5cb7. Consider uploading reports for the commit 06a5cb7 to get more accurate results

@@             Coverage Diff              @@
##             master     #335      +/-   ##
============================================
- Coverage     88.91%   88.86%   -0.05%     
  Complexity      628      628              
============================================
  Files           152      152              
  Lines          6271     6271              
  Branches        299      299              
============================================
- Hits           5576     5573       -3     
- Misses          610      612       +2     
- Partials         85       86       +1     
Impacted Files Coverage Δ
...luxdb/client/kotlin/InfluxDBClientKotlinFactory.kt 72.00% <ø> (ø)
...client/reactive/InfluxDBClientReactiveFactory.java 100.00% <ø> (ø)
...uxdb/client/scala/InfluxDBClientScalaFactory.scala 80.00% <ø> (ø)
...ava/com/influxdb/client/InfluxDBClientFactory.java 100.00% <ø> (ø)
...ava/com/influxdb/client/InfluxDBClientOptions.java 94.80% <100.00%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b26209...06a5cb7. Read the comment docs.

@bednar bednar merged commit e084b2e into master Apr 14, 2022
@bednar bednar deleted the url_as_connection_string branch April 14, 2022 10:30
@bednar bednar added this to the 6.0.0 milestone Apr 14, 2022
@bednar bednar added the enhancement New feature or request label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants